Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user agent changed to support mobile view as well as solve issue with… #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roshangm1
Copy link

Show mobile version site when logging with facebook and it also fixes Disallow UserAgent issue with Google login.

… disallow user agent for google login in webview
@alexkendall
Copy link

This is happening with google also.

@dieseldjango
Copy link

This isn't the right way to fix the disallow useragent issue on Google. They're pretty clear on how they expect this to be implemented: https://developers.googleblog.com/2016/08/modernizing-oauth-interactions-in-native-apps.html.

Copy link

@ericchan3721 ericchan3721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better using the user's actual UserAgent and replace wv from it instead of the hard coded one
mWebView.getSettings().setUserAgentString(mWebView.getSettings().getUserAgentString().replace("; wv", ""));

Ref: https://developers.googleblog.com/2016/08/modernizing-oauth-interactions-in-native-apps.html

P.S. I have open the PR for this issue, however this library seems no longer supported by the original author, you may consider using other OAuth RN library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants